linux-kernel - Re: [PATCH #3] reiserfs: Fix permissions on .reiserfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1270766367.3441.4.camel@mattlaptop2.local>
Date:	Thu, 08 Apr 2010 18:39:27 -0400
From:	Matt McCutchen <matt@...tmccutchen.net>
To:	ReiserFS Mailing List <reiserfs-devel@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Cc:	Edward Shishkin <edward.shishkin@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jeff Mahoney <jeffm@...e.com>
Subject: Re: [PATCH #3] reiserfs: Fix permissions on .reiserfs_priv

On Thu, 2010-04-08 at 23:38 +0200, Edward Shishkin wrote:
> Jeff Mahoney wrote:
> >  [...] This patch resolves the issue by properly hiding .reiserfs_priv. This
> >  was the intent of the xattr poisoning code, but it appears to have
> >  never worked as expected. This is fixed by using d_revalidate instead
> >  of d_compare. [...]

The patch seems to rely on the fact that the priv_root dentry is stuck
in the dcache for as long as the filesystem is mounted, so that attempts
to follow ".reiserfs_priv" are guaranteed to match that dentry in the
cache and be refused by xattr_hide_revalidate.  Is my understanding
correct?

-- 
Matt

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/