linux-kernel - Re: [PATCH 7/8] USB: testusb: imported David Brownell's USB testing application

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 7 Apr 2010 23:18:46 -0700
From:	Greg KH <greg@...ah.com>
To:	Heikki Krogerus <ext-heikki.krogerus@...ia.com>
Cc:	ext Michal Nazarewicz <m.nazarewicz@...sung.com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	Peter Korsgaard <jacmet@...site.dk>,
	Rupesh Gujare <rupeshgujare@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	David Brownell <dbrownell@...rs.sourceforge.net>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>
Subject: Re: [PATCH 7/8] USB: testusb: imported David Brownell's USB
	testing application

On Thu, Apr 08, 2010 at 09:10:00AM +0300, Heikki Krogerus wrote:
> Hi,
> 
> If this is going into kernel then..
> 
> On Wed, Apr 07, 2010 at 03:41:34PM +0200, ext Michal Nazarewicz wrote:
> 
> ...
> 
> > +       if ((c = open ("/proc/bus/usb/devices", O_RDONLY)) < 0) {
> > +               fputs ("usbfs files are missing\n", stderr);
> > +               return -1;
> > +       }
> 
> Is this needed?
> 
> > +
> > +       /* collect and list the test devices */
> > +       if (ftw ("/proc/bus/usb", find_testdev, 3) != 0) {
> 
> How about "/dev/bus/usb" instead? Some distributions do not enable
> sysfs in their default kernels anymore.

You mean 'usbfs' not 'sysfs', right?

And yes, this probably should be fixed, patches are always welcome :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/