linux-kernel - Re: [PATCH 04/12] frv: remove "struct file *" argument from sysctl ->proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <u2xb6fcc0a1004090923h261c099fpc40b3c289e981b28@mail.gmail.com>
Date:	Fri, 9 Apr 2010 19:23:50 +0300
From:	Alexey Dobriyan <adobriyan@...il.com>
To:	Jan Blunck <jblunck@...e.de>
Cc:	Linux-Kernel Mailinglist <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Arnd Bergmann <arnd@...db.de>, Alan Cox <alan@...ux.intel.com>
Subject: Re: [PATCH 04/12] frv: remove "struct file *" argument from sysctl 
	->proc_handler

On Fri, Apr 9, 2010 at 5:00 PM, Jan Blunck <jblunck@...e.de> wrote:
> Seems that Alexey Dobriyan missed this usage of the file argument when
> removing it from ->proc_handler in commit 8d65af789f3e2cf4cfbdbf71a0f7a61ebcd41d38.

It wasn't missed, it was deliberately left out because I didn't understand
what's going on there.

I mean, sysctl handler touching ->f_pos, come on!

What's going on?

> --- a/arch/frv/kernel/sysctl.c
> +++ b/arch/frv/kernel/sysctl.c
> @@ -85,7 +86,7 @@ static int procctl_frv_cachemode(ctl_table *table, int write, struct file *filp,
>        }
>
>        /* read the state */
> -       if (filp->f_pos > 0) {
> +       if (*ppos > 0) {
>                *lenp = 0;
>                return 0;
>        }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/