linux-kernel - Re: [PATCH] Staging: asus_oled: asus_oled.c removed an unnessecary space, making it checkpatch clean

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100409172250.GA15900@suse.de>
Date:	Fri, 9 Apr 2010 10:22:50 -0700
From:	Greg KH <gregkh@...e.de>
To:	Gunnar Gudvardarson <gunni@...e.is>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: asus_oled: asus_oled.c removed an unnessecary
 space, making it checkpatch clean

On Fri, Apr 09, 2010 at 01:01:09PM +0000, Gunnar Gudvardarson wrote:
> This is the first linux kernel patch i have ever made, i don't even
> know the C programming language except reading the syntax (basic)

Then I would strongly encourage you to either learn it, or not modify
the code.

> It didn't compile on my machine due to invalid configuration of something
> on my machine, because i have not yet learned how to configure the compiler.

Especially as you were not able to build test the patch, which is a
basic requirement for submitting code changes.

Try reading the kernel file, Documentation/HOWTO for pointers on how to
find information to learn the C language, and to learn how to build a
kernel on your own.

best of luck,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/