linux-kernel - Re: [PATCH 02/16] viafb: use proper pci config API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100409134610.0b610f93@bike.lwn.net>
Date:	Fri, 9 Apr 2010 13:46:10 -0600
From:	Jonathan Corbet <corbet@....net>
To:	Florian Tobias Schandinat <FlorianSchandinat@....de>
Cc:	linux-kernel@...r.kernel.org, Harald Welte <laforge@...monks.org>,
	JosephChan@....com.tw, ScottFang@...tech.com.cn,
	Deepak Saxena <dsaxena@...top.org>,
	linux-fbdev-devel@...ts.sourceforge.net
Subject: Re: [PATCH 02/16] viafb: use proper pci config API

On Thu, 08 Apr 2010 20:42:17 +0200
Florian Tobias Schandinat <FlorianSchandinat@....de> wrote:

> something I am wondering about is whether we can't simply do:
> viaparinfo->memsize = pci_resource_len(pdev, 0);
> I suppose that this is not possible meaning that the pci len can be 
> longer than the actual memory but I just wanted to use the moment to 
> make sure.

That would make sense.  But if somebody who is closer to the hardware than
I am doesn't take that approach, I'm nervous about changing it.  Harald?

> This function was not designed to return an error (memsize is not 
> checked). Either return a default value (let's say 8MB) or add a check 
> for memsize.

That's a good point.  I put in a check.

Thanks,

jon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/