linux-kernel - Re: [PATCH 10/16] suppress verbose debug messages: change printk() to DEBUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4BBFA582.2010701@gmx.de>
Date:	Sat, 10 Apr 2010 00:09:06 +0200
From:	Florian Tobias Schandinat <FlorianSchandinat@....de>
To:	Jonathan Corbet <corbet@....net>
CC:	linux-kernel@...r.kernel.org, Harald Welte <laforge@...monks.org>,
	JosephChan@....com.tw, ScottFang@...tech.com.cn,
	Deepak Saxena <dsaxena@...top.org>,
	linux-fbdev-devel@...ts.sourceforge.net
Subject: Re: [PATCH 10/16] suppress verbose debug messages:  change printk()
 to DEBUG_MSG()

This patch is fine.


Thanks,

Florian Tobias Schandinat

Jonathan Corbet schrieb:
> From: Paul Fox <pgf@...top.org>
> 
> ---
>  drivers/video/via/via_i2c.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/video/via/via_i2c.c b/drivers/video/via/via_i2c.c
> index 18bbbdd..86e6e8d 100644
> --- a/drivers/video/via/via_i2c.c
> +++ b/drivers/video/via/via_i2c.c
> @@ -26,7 +26,7 @@ static void via_i2c_setscl(void *data, int state)
>  	u8 val;
>  	struct via_i2c_adap_cfg *adap_data = data;
>  
> -	printk(KERN_DEBUG "reading index 0x%02x from IO 0x%x\n",
> +	DEBUG_MSG(KERN_DEBUG "reading index 0x%02x from IO 0x%x\n",
>  		adap_data->ioport_index, adap_data->io_port);
>  	val = viafb_read_reg(adap_data->io_port,
>  			     adap_data->ioport_index) & 0xF0;
> @@ -140,7 +140,7 @@ static int create_i2c_bus(struct i2c_adapter *adapter,
>  			  struct via_i2c_adap_cfg *adap_cfg,
>  			  struct pci_dev *pdev)
>  {
> -	printk(KERN_DEBUG "viafb: creating bus adap=0x%p, algo_bit_data=0x%p, adap_cfg=0x%p\n", adapter, algo, adap_cfg);
> +	DEBUG_MSG(KERN_DEBUG "viafb: creating bus adap=0x%p, algo_bit_data=0x%p, adap_cfg=0x%p\n", adapter, algo, adap_cfg);
>  
>  	algo->setsda = via_i2c_setsda;
>  	algo->setscl = via_i2c_setscl;
> @@ -182,7 +182,7 @@ static struct via_i2c_adap_cfg adap_configs[] = {
>  int viafb_create_i2c_busses(struct viafb_par *viapar)
>  {
>  	int i, ret;
> -	printk(KERN_DEBUG "%s: entering\n", __FUNCTION__);
> +	DEBUG_MSG(KERN_DEBUG "%s: entering\n", __FUNCTION__);
>  
>  	for (i = 0; i < VIAFB_NUM_I2C; i++) {
>  		struct via_i2c_adap_cfg *adap_cfg = &adap_configs[i];

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/