linux-kernel - Re: [PATCH] Staging: dream: smd: smd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <g2of5ca57691004101109k1e8c37a9mc65b07e22eda9cd5@mail.gmail.com>
Date:	Sat, 10 Apr 2010 14:09:33 -0400
From:	Chihau Chau <chihau@...il.com>
To:	Pavel Machek <pavel@....cz>
Cc:	Greg KH <greg@...ah.com>, gregkh@...e.de,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: dream: smd: smd_private: fix code style issues

So, What about this patch? Greg?

2010/3/15 Pavel Machek <pavel@....cz>:
> On Mon 2010-03-15 00:29:02, Chihau Chau wrote:
>> From: Chihau Chau <chihau@...il.com>
>>
>> This put open braces '{' following structs on the same line.
>>
>> Signed-off-by: Chihau Chau <chihau@...il.com>
>
> ACK.
>
>> ---
>>  drivers/staging/dream/smd/smd_private.h |   21 +++++++--------------
>>  1 files changed, 7 insertions(+), 14 deletions(-)
>>
>> diff --git a/drivers/staging/dream/smd/smd_private.h b/drivers/staging/dream/smd/smd_private.h
>> index c0eb3de..1b2e1c8 100644
>> --- a/drivers/staging/dream/smd/smd_private.h
>> +++ b/drivers/staging/dream/smd/smd_private.h
>> @@ -16,24 +16,21 @@
>>  #ifndef _ARCH_ARM_MACH_MSM_MSM_SMD_PRIVATE_H_
>>  #define _ARCH_ARM_MACH_MSM_MSM_SMD_PRIVATE_H_
>>
>> -struct smem_heap_info
>> -{
>> +struct smem_heap_info {
>>       unsigned initialized;
>>       unsigned free_offset;
>>       unsigned heap_remaining;
>>       unsigned reserved;
>>  };
>>
>> -struct smem_heap_entry
>> -{
>> +struct smem_heap_entry {
>>       unsigned allocated;
>>       unsigned offset;
>>       unsigned size;
>>       unsigned reserved;
>>  };
>>
>> -struct smem_proc_comm
>> -{
>> +struct smem_proc_comm {
>>       unsigned command;
>>       unsigned status;
>>       unsigned data1;
>> @@ -49,22 +46,19 @@ struct smem_proc_comm
>>  #define VERSION_APPS      8
>>  #define VERSION_MODEM     9
>>
>> -struct smem_shared
>> -{
>> +struct smem_shared {
>>       struct smem_proc_comm proc_comm[4];
>>       unsigned version[32];
>>       struct smem_heap_info heap_info;
>>       struct smem_heap_entry heap_toc[128];
>>  };
>>
>> -struct smsm_shared
>> -{
>> +struct smsm_shared {
>>       unsigned host;
>>       unsigned state;
>>  };
>>
>> -struct smsm_interrupt_info
>> -{
>> +struct smsm_interrupt_info {
>>       uint32_t aArm_en_mask;
>>       uint32_t aArm_interrupts_pending;
>>       uint32_t aArm_wakeup_reason;
>> @@ -108,8 +102,7 @@ void smsm_print_sleep_info(void);
>>
>>  #define SMEM_NUM_SMD_CHANNELS        64
>>
>> -typedef enum
>> -{
>> +typedef enum {
>>       /* fixed items */
>>       SMEM_PROC_COMM = 0,
>>       SMEM_HEAP_INFO,
>
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
>



-- 
Chihau Chau
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/