linux-kernel - Re: [PATCH 3/3] fbmem, drm/nouveau: kick firmware framebuffers as soon as possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100411170900.GB4016@joi.lan>
Date:	Sun, 11 Apr 2010 19:09:00 +0200
From:	Marcin Slusarz <marcin.slusarz@...il.com>
To:	LKML <linux-kernel@...r.kernel.org>,
	dri-devel <dri-devel@...ts.freedesktop.org>
Cc:	nouveau@...ts.freedesktop.org, linux-fbdev@...r.kernel.org,
	Ben Skeggs <bskeggs@...hat.com>,
	Dave Airlie <airlied@...hat.com>,
	Peter Jones <pjones@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Didier Spaier <didier.spaier@...m.fr>
Subject: Re: [PATCH 3/3] fbmem, drm/nouveau: kick firmware framebuffers as
 soon as possible

On Sat, Apr 10, 2010 at 09:55:34PM +0200, marcin.slusarz@...il.com wrote:
> Currently vesafb/efifb/... is kicked when hardware driver is registering
> framebuffer. To do it hardware must be fully functional, so there's a short
> window between start of initialisation and framebuffer registration when
> two drivers touch the hardware. Unfortunately sometimes it breaks nouveau
> initialisation.
> 
> Fix it by kicking firmware driver(s) before we start touching the hardware.
> 
> Reported-by: Didier Spaier <didier.spaier@...m.fr>
> Signed-off-by: Marcin Slusarz <marcin.slusarz@...il.com>
> Cc: Ben Skeggs <bskeggs@...hat.com>
> Cc: Dave Airlie <airlied@...hat.com>
> Cc: Peter Jones <pjones@...hat.com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> ---

With this little patch below:
Tested-by: Didier Spaier <didier.spaier@...m.fr>

---
diff --git a/drivers/video/fbmem.c b/drivers/video/fbmem.c
index f5297a0..42ae782 100644
--- a/drivers/video/fbmem.c
+++ b/drivers/video/fbmem.c
@@ -1524,6 +1524,7 @@ void remove_conflicting_framebuffers(struct apertures_struct *a, const char *nam
 		}
 	}
 }
+EXPORT_SYMBOL(remove_conflicting_framebuffers);
 
 /**
  *	register_framebuffer - registers a frame buffer device

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/