linux-kernel - Re: [PATCH v6 7/8, needs improvement] hid: add suspend/resume hooks for hid drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201004112227.32045.oliver@neukum.org>
Date:	Sun, 11 Apr 2010 22:27:32 +0200
From:	Oliver Neukum <oliver@...kum.org>
To:	Bruno Prémont <bonbons@...ux-vserver.org>
Cc:	Jiri Kosina <jkosina@...e.cz>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-input@...r.kernel.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	"Rick L. Vinyard Jr." <rvinyard@...nmsu.edu>,
	Nicu Pavel <npavel@...ner.com>
Subject: Re: [PATCH v6 7/8, needs improvement] hid: add suspend/resume hooks for hid drivers

Am Sonntag, 11. April 2010 20:40:02 schrieb Bruno Prémont:
> On Sun, 11 April 2010 Jiri Kosina <jkosina@...e.cz> wrote:
> > > As far as I understand the code, in auto-suspend case if the driver 
> > > sends commands to the device it will have to call usbhid_wait_io(). 
> > > Please correct me if I'm wrong!
> > 
> > It's not needed. There is a queuing mechanism in place on 
> > 'resumption_waker' workqueue.
> 
> So the driver is not allowed to ask the device to do something
> at auto-suspend time (as that would abort the auto-suspension).

>From within suspend()?

Generally if the driver wants to talk to a device that's a good
reason to wake up a device.

	Regards
		Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/