linux-kernel - Re: LOCALVERSION_AUTO considered harmful

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1004120022230.18009@localhost.localdomain>
Date:	Mon, 12 Apr 2010 00:24:10 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Pavel Machek <pavel@....cz>
cc:	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Alexey Dobriyan <adobriyan@...il.com>,
	kernel list <linux-kernel@...r.kernel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...l.org>
Subject: Re: LOCALVERSION_AUTO considered harmful

On Sun, 11 Apr 2010, Pavel Machek wrote:

> On Sun 2010-04-11 20:58:58, Geert Uytterhoeven wrote:
> > On Mon, Apr 12, 2010 at 20:51, Alexey Dobriyan <adobriyan@...il.com> wrote:
> > > On Sun, Apr 11, 2010 at 06:47:01PM +0200, Pavel Machek wrote:
> > >> @@ -99,6 +98,11 @@ config LOCALVERSION_AUTO
> > >>         appended after any matching localversion* files, and after the value
> > >>         set in CONFIG_LOCALVERSION.
> > >>
> > >> +       Unfortunately, such finegrained versioning will mean that you will
> > >> +       not be able to use modules for development; even "make modules"
> > >> +       will change module versions, making recompiled modules impossible
> > >> +       to insert into old kernel.
> > >
> > > That's conditional BS.
> > > Turn off CONFIG_MODVERSIONS already.
> > 
> > Yeah, I disabled it ages ago. Even then (before git, probably even
> > before bitkeeper)
> > I had hard times inserting modules...
> 
> I _had_ it off
> 
>  # CONFIG_MODVERSIONS is not set
> 
> It seems some checking survives CONFIG_MODVERSIONS unset and that
> checking is strict enough to refuse module load after one "make
> modules" with LOCALVERSION_AUTO on...

So instead of fixing the CONFIG_MODVERSIONS=n case you go the easy way
of killing LOCALVERSION_AUTO ? Brilliant.

Thanks,

	tglx