linux-kernel - Re: [PATCH] fix cgroup procs documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100409034850.GA596@unix11.andrew.cmu.edu>
Date:	Thu, 8 Apr 2010 23:48:50 -0400
From:	Ben Blum <bblum@...rew.cmu.edu>
To:	Li Zefan <lizf@...fujitsu.com>
Cc:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	"menage@...gle.com" <menage@...gle.com>,
	"nishimura@....nes.nec.co.jp" <nishimura@....nes.nec.co.jp>,
	stable@...nel.org, Ben Blum <bblum@...rew.cmu.edu>,
	Oleg Nesterov <oleg@...hat.com>
Subject: Re: [PATCH] fix cgroup procs documentation

On Fri, Apr 09, 2010 at 11:31:54AM +0800, Li Zefan wrote:
> Cc: Ben Blum
> 
> KAMEZAWA Hiroyuki wrote:
> > On Fri, 09 Apr 2010 11:22:00 +0800
> > Li Zefan <lizf@...fujitsu.com> wrote:
> > 
> >> KAMEZAWA Hiroyuki wrote:
> >>> 2.6.33's Documentation has the same wrong information. So, I CC'ed to stable.
> >>> If people believe this information, they'll usr cgroup.procs file and will
> >>> see cgroup doesn'w work as expected.
> >>> The patch itself is against -mm.
> >>>
> >>> ==
> >>> Writing to cgroup.procs is not supported now.
> >>>
> >>> Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
> >>> ---
> >>>  Documentation/cgroups/cgroups.txt |    3 +--
> >>>  1 file changed, 1 insertion(+), 2 deletions(-)
> >>>
> >>> Index: mmotm-temp/Documentation/cgroups/cgroups.txt
> >>> ===================================================================
> >>> --- mmotm-temp.orig/Documentation/cgroups/cgroups.txt
> >>> +++ mmotm-temp/Documentation/cgroups/cgroups.txt
> >>> @@ -235,8 +235,7 @@ containing the following files describin
> >>>   - cgroup.procs: list of tgids in the cgroup.  This list is not
> >>>     guaranteed to be sorted or free of duplicate tgids, and userspace
> >>>     should sort/uniquify the list if this property is required.
> >>> -   Writing a tgid into this file moves all threads with that tgid into
> >>> -   this cgroup.
> >>> +   This is a read-only file, now.
> >> I think the better wording is "for now". :)
> >>
> > ok. BTW, does anyone work on this ?
> 
> It was Ben Blum, don't know if he's still working on it.

Aye. Oleg suggested a redesign of the last patch (putting the lock in
signal_struct instead of sighand_struct), but I haven't got time to work
on them now. Expect a revision in maybe two months...

> 
> > ==
> > 
> > Writing to cgroup.procs is not supported now.
> > 
> > Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
> 
> Acked-by: Li Zefan <lizf@...fujitsu.com>
> 
> > ---
> >  Documentation/cgroups/cgroups.txt |    3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > Index: mmotm-temp/Documentation/cgroups/cgroups.txt
> > ===================================================================
> > --- mmotm-temp.orig/Documentation/cgroups/cgroups.txt
> > +++ mmotm-temp/Documentation/cgroups/cgroups.txt
> > @@ -235,8 +235,7 @@ containing the following files describin
> >   - cgroup.procs: list of tgids in the cgroup.  This list is not
> >     guaranteed to be sorted or free of duplicate tgids, and userspace
> >     should sort/uniquify the list if this property is required.
> > -   Writing a tgid into this file moves all threads with that tgid into
> > -   this cgroup.
> > +   This is a read-only file, for now.
> >   - notify_on_release flag: run the release agent on exit?
> >   - release_agent: the path to use for release notifications (this file
> >     exists in the top cgroup only)
> > 
> > 
> > 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/