linux-kernel - Re: 2.6.34-rc2: "ima_dec_counts: open/free imbalance"?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1271071620.3125.30.camel@localhost.localdomain>
Date:	Mon, 12 Apr 2010 07:27:00 -0400
From:	Mimi Zohar <zohar@...ux.vnet.ibm.com>
To:	Thomas Meyer <thomas@...3r.de>
Cc:	Eric Paris <eparis@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Mimi Zohar <zohar@...ibm.com>,
	James Morris <jmorris@...ei.org>,
	"dri-devel@...ts.sourceforge.net" <dri-devel@...ts.sourceforge.net>
Subject: Re: 2.6.34-rc2: "ima_dec_counts: open/free imbalance"?

On Thu, 2010-04-01 at 20:17 +0200, Thomas Meyer wrote:
> Am 01.04.2010 um 04:41 schrieb Eric Paris <eparis@...hat.com>:
> 
> > On Wed, 2010-03-31 at 16:32 -0700, Andrew Morton wrote:
> >> On Sun, 28 Mar 2010 13:31:49 +0200
> >> Thomas Meyer <thomas@...3r.de> wrote:
> >>
> >>> This warning/error/notice is new in 2.6.34-rc2+:
> >>
> >> Let's add some cc's.  It might be a DRM bug.
> >>
> >> I'll ask Rafael and Maciej to track this as a post-2.6.33 regression,
> >> thanks.
> >
> > The IMA code hasn't changed since .33 so my guess is something new the
> > drm code is doing with obj->filp.
> >
> > Thomas, any idea what the newest kernel was that didn't show you this
> > problem?
> 
> I first saw this message in 2.6.34-rc2 (+free_init_pages patch), but  
> that was also the first bootable kernel for me as I was hit by the  
> NO_BOOTMEM bug...
> 
> >  It might help cut down my search in the morning....
> >
> > -Eric
> >

The call to shmem_file_setup() in drm_gem_object_alloc() should properly
increment the IMA counters and the fput() in
drm_gem_object_free_common() should decrement them.

I noticed the 'bump' comment in 'include/drm/drmP.h' doesn't match the
code, but in fact does the exact opposite.  Not sure if this is related.

static inline void
drm_gem_object_handle_unreference(struct drm_gem_object *obj)
{
        if (obj == NULL)
                return;

        /*
         * Must bump handle count first as this may be the last
         * ref, in which case the object would disappear before we
         * checked for a name
         */
        kref_put(&obj->handlecount, drm_gem_object_handle_free);
        drm_gem_object_unreference(obj);
}

Mimi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/