linux-kernel - Re: [PATCH] Revert "memory-hotplug: add 0x prefix to HEX block_size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 12 Apr 2010 07:41:59 +0200
From:	Pavel Machek <pavel@....cz>
To:	Am?rico Wang <xiyou.wangcong@...il.com>
Cc:	Heiko Carstens <heiko.carstens@...ibm.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org,
	Wu Fengguang <fengguang.wu@...el.com>,
	Andi Kleen <andi@...stfloor.org>, Greg KH <greg@...ah.com>,
	Gerald Schaefer <gerald.schaefer@...ibm.com>, stable@...nel.org
Subject: Re: [PATCH] Revert "memory-hotplug: add 0x prefix to HEX
	block_size_bytes"

On Thu 2010-04-08 23:41:24, Am?rico Wang wrote:
> On Thu, Apr 08, 2010 at 05:10:06PM +0200, Heiko Carstens wrote:
> >From: Heiko Carstens <heiko.carstens@...ibm.com>
> >
> >Revert ba168fc37dea145deeb8fa9e7e71c748d2e00d74 "memory-hotplug: add 0x prefix
> >to HEX block_size_bytes" since it changes the user space visible sysfs interface
> >/sys/devices/system/memory/block_size_bytes.
> >The change breaks existing user space applications which rely on the fact that
> >the output does not contain the "0x" prefix.
> >
> 
> Odd.
> 
> Which application relies on this? Isn't the application which should
> be fixed?? It should use something like strtoul() which doesn't
> rely on '0x' prefix.

'no regressions'?!

You should not randomly change kernel api, then blame it on applications.
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/