linux-kernel - Re: [PATCH -mm 2/3] proc: make collect_sigign

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100412202614.GA18802@redhat.com>
Date:	Mon, 12 Apr 2010 22:26:14 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Roland McGrath <roland@...hat.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Alexey Dobriyan <adobriyan@...il.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH -mm 2/3] proc: make collect_sigign_sigcatch() rcu-safe

On 04/09, Roland McGrath wrote:
>
> > In theory, this ->sighand can be re-used under us (but it can't go away).
> > We could check task->sighand == sighand once again after the main loop
> > to prevent the race with exit/exec, but I don't think this is really
> > needed for fs/proc.
>
> In v2.6.34-rc3-500-g0eddb51 this isn't possible because the calls from
> task_sig() and do_task_stat() are under siglock.

Yes sure. If it is called under ->siglock we have no races we should
worry about.

> Is that locking removed
> by another pending change?

Yes, the next 3/3 patch.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/