lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 14 Apr 2010 15:50:07 +0300 From: Alexey Dobriyan <adobriyan@...il.com> To: Patrick McHardy <kaber@...sh.net> Cc: linux-kernel@...r.kernel.org, netdev@...r.kernel.org, shemminger@...tta.com, bhutchings@...arflare.com, andreas@...al.se, hadi@...erus.ca, hideaki@...hifuji.org Subject: Re: [PATCH v2] xtables: make XT_ALIGN() usable in exported headers by exporting __ALIGN_KERNEL() On Tue, Apr 13, 2010 at 01:08:20PM +0200, Patrick McHardy wrote: > Alexey Dobriyan wrote: > > XT_ALIGN() was rewritten through ALIGN() by commit 42107f5009da223daa800d6da6904d77297ae829 > > "netfilter: xtables: symmetric COMPAT_XT_ALIGN definition". > > ALIGN() is not exported in userspace headers, which created compile problem for tc(8) > > and will create problem for iptables(8). > > > > We can't export generic looking name ALIGN() but we can export less generic > > __ALIGN_KERNEL() (suggested by Ben Hutchings). > > Google knows nothing about __ALIGN_KERNEL(). > > > > COMPAT_XT_ALIGN() changed for symmetry. > > I've already pushed your change out, could you send me an incremental > fix please? > > master.kernel.org:/pub/scm/linux/kernel/git/kaber/nf-next-2.6.git [PATCH] Restore __ALIGN_MASK() Fix lib/bitmap.c compile failure due to __ALIGN_KERNEL changes. --- --- a/include/linux/kernel.h +++ b/include/linux/kernel.h @@ -40,6 +40,7 @@ extern const char linux_proc_banner[]; #define STACK_MAGIC 0xdeadbeef #define ALIGN(x, a) __ALIGN_KERNEL((x), (a)) +#define __ALIGN_MASK(x, mask) __ALIGN_KERNEL_MASK((x), (mask)) #define PTR_ALIGN(p, a) ((typeof(p))ALIGN((unsigned long)(p), (a))) #define IS_ALIGNED(x, a) (((x) & ((typeof(x))(a) - 1)) == 0) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists