linux-kernel - Re: [PATCH 1/4] blkdev: pass gfp_mask and flags to blkdev_issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100413180836.GA1483@infradead.org>
Date:	Tue, 13 Apr 2010 14:08:36 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Dmitry Monakhov <dmonakhov@...nvz.org>
Cc:	linux-kernel@...r.kernel.org, jens.axboe@...cle.com,
	hch@...radead.org
Subject: Re: [PATCH 1/4] blkdev: pass gfp_mask and flags to
	blkdev_issue_flush

On Mon, Apr 12, 2010 at 05:03:54PM +0400, Dmitry Monakhov wrote:
> In some places caller don't want to wait a request to complete.
> Flags make blkdev_issue_flush() more flexible. This patch just
> convert existing callers to new interface without chaining
> existing allocation/wait behavior.

Looks okay to me, but as mention in the other review I would introduce
the comment flags first and then add the flags to blkdev_issue_flush,
not the other way around.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/