linux-kernel - Re: [PATCH -next] eeepc-wmi: depends on INPUT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201004131539.34998.dmitry.torokhov@gmail.com>
Date:	Tue, 13 Apr 2010 15:39:34 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	Matthew Garrett <mjg@...hat.com>, linux-next@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH -next] eeepc-wmi: depends on INPUT_SPARSEKMAP

On Tuesday 13 April 2010 09:45:44 am Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@...cle.com>
> 
> When EEEPC_WMI=y and INPUT_SPARSEKMAP=m, the build fails,
> so make EEEPC_WMI depend on INPUT_SPARSEKMAP.
> 
> eeepc-wmi.c:(.text+0x28d1a9): undefined reference to `sparse_keymap_setup'
> eeepc-wmi.c:(.text+0x28d1f9): undefined reference to `sparse_keymap_free'
> eeepc-wmi.c:(.text+0x28d2e0): undefined reference to
> `sparse_keymap_report_event' eeepc-wmi.c:(.init.text+0x17069): undefined
> reference to `sparse_keymap_free' eeepc-wmi.c:(.exit.text+0x2bae):
> undefined reference to `sparse_keymap_free'
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
> ---
>  drivers/platform/x86/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-next-20100413.orig/drivers/platform/x86/Kconfig
> +++ linux-next-20100413/drivers/platform/x86/Kconfig
> @@ -388,7 +388,7 @@ config EEEPC_LAPTOP
>  config EEEPC_WMI
>  	tristate "Eee PC WMI Hotkey Driver (EXPERIMENTAL)"
>  	depends on ACPI_WMI
> -	depends on INPUT
> +	depends on INPUT && INPUT_SPARSEKMAP

"select INPUT_SPARSEKMAP" please - users should not be concerned about
such implementation details.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/