linux-kernel - Re: Security: Replace dac_mmap_min_addr to mmap_min_addr in cap_file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100414073554.GB4503@cr0.nay.redhat.com>
Date:	Wed, 14 Apr 2010 15:35:54 +0800
From:	Amerigo Wang <xiyou.wangcong@...il.com>
To:	wzt wzt <wzt.wzt@...il.com>
Cc:	Eric Paris <eparis@...isplace.org>, linux-kernel@...r.kernel.org,
	linux-security-module@...r.kernel.org, jmorris@...ei.org
Subject: Re: Security: Replace dac_mmap_min_addr to mmap_min_addr in
 cap_file_mmap()

On Wed, Apr 14, 2010 at 01:50:40PM +0800, wzt wzt wrote:
>still not understand,  if CONFIG_LSM_MMAP_MIN_ADDR is not set,
>mmap_min_addr is equal dac_mmap_min_addr, right?
>if not, mmap_min_addr is set as CONFIG_LSM_MMAP_MIN_ADDR.  what's the
>effect of mmap_min_addr?  except round_hint_to_min() will use
>mmap_min_addr, any other functions will call it?

round_hint_to_min() will be called by mmap().

As the names tell you, mmap_min_addr will be checked by mmap(),
dac_mmap_min_addr will be checked for CAP_SYS_RAWIO.

Please check commit 788084ab, as Eric suggested.

>Anyway, the comments need change mmap_min_addr as dac_mmap_min_addr,
>right? If i'm wrong, please point it, thanks.
>/*
> * If the process is attempting to map memory below mmap_min_addr they need   |{
> * CAP_SYS_RAWIO.
> */
>

Yes, I think the comment needs to be fixed.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/