linux-kernel - Re: [PATCH 5/6] ceph: refactor mount related functions, add helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87bpdm9x0e.fsf@basil.nowhere.org>
Date:	Wed, 14 Apr 2010 11:57:53 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Yehuda Sadeh <yehuda@...newdream.net>
Cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	yehudasa@...il.com, sage@...dream.net, axboe@...nel.dk
Subject: Re: [PATCH 5/6] ceph: refactor mount related functions, add helpers

Yehuda Sadeh <yehuda@...newdream.net> writes:
>  
> +int ceph_copy_to_page_vector(struct page **pages,
> +				    const char *data,
> +				    loff_t off, size_t len)
> +{
> +	int i = 0;
> +	int po = off & ~PAGE_CACHE_MASK;
> +	int left = len;
> +	int l;
> +
> +	while (left > 0) {
> +		l = min_t(int, PAGE_CACHE_SIZE-po, left);

int seems like exactly the wrong type here.

-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/