linux-kernel - Re: [PATCH][resend] namei.c : update mnt when it needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100414044805.GE3919@cr0.nay.redhat.com>
Date:	Wed, 14 Apr 2010 12:48:05 +0800
From:	Amerigo Wang <xiyou.wangcong@...il.com>
To:	Huang Shijie <shijie8@...il.com>
Cc:	akpm@...ux-foundation.org, viro@...iv.linux.org.uk,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH][resend] namei.c : update mnt when it needed

On Wed, Apr 14, 2010 at 10:16:09AM +0800, Huang Shijie wrote:
>update the mnt of the path when it is not equal to the new one.
>
>Signed-off-by: Huang Shijie <shijie8@...il.com>


This change is trivial, and it looks fine for me.

Reviewed-by: WANG Cong <xiyou.wangcong@...il.com>

Thanks!


>---
> fs/namei.c |    5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/fs/namei.c b/fs/namei.c
>index a7dce91..9c3a040 100644
>--- a/fs/namei.c
>+++ b/fs/namei.c
>@@ -523,9 +523,10 @@ static void path_put_conditional(struct path *path, struct nameidata *nd)
> static inline void path_to_nameidata(struct path *path, struct nameidata *nd)
> {
> 	dput(nd->path.dentry);
>-	if (nd->path.mnt != path->mnt)
>+	if (nd->path.mnt != path->mnt) {
> 		mntput(nd->path.mnt);
>-	nd->path.mnt = path->mnt;
>+		nd->path.mnt = path->mnt;
>+	}
> 	nd->path.dentry = path->dentry;
> }
> 
>-- 
>1.6.6
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@...r.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/