linux-kernel - Re: [PATCH] blkio: Fix linux-next build failure after merge of block tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100415065615.GQ27497@kernel.dk>
Date:	Thu, 15 Apr 2010 08:56:15 +0200
From:	Jens Axboe <jens.axboe@...cle.com>
To:	Divyesh Shah <dpshah@...gle.com>
Cc:	sfr@...b.auug.org.au, guijianfeng@...fujitsu.com,
	vgoyal@...hat.com, linux-next@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] blkio: Fix linux-next build failure after merge of
	block tree

On Wed, Apr 14 2010, Divyesh Shah wrote:
> After merging the block tree, 20100414's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> ERROR: "get_gendisk" [block/blk-cgroup.ko] undefined!
> ERROR: "sched_clock" [block/blk-cgroup.ko] undefined!
> 
> This happens because the two symbols aren't exported and hence not available
> when blk-cgroup code is built as a module. I've tried to stay consistent with
> the use of EXPORT_SYMBOL or EXPORT_SYMBOL_GPL with the other symbols in the
> respective files.

Thanks, applied. I changed the subject to say 'fix for modular
blk-cgroup build', as that is a lot more descriptive than saying you
fixed linux-next build. It's more informative to note the actual
problem, not how it was discovered.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/