linux-kernel - Re: [PATCH] ALSA: Add initial support for Thinkpad T410s HDA codec.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hr5mh2nnr.wl%tiwai@suse.de>
Date:	Thu, 15 Apr 2010 09:14:00 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Jens Taprogge <jens.taprogge@...rogge.org>
Cc:	Jaroslav Kysela <perex@...ex.cz>, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: Add initial support for Thinkpad T410s HDA codec.

At Wed, 14 Apr 2010 23:42:04 +0200,
Jens Taprogge wrote:
> 
> Dear ALSA Maintainers,
> 
> attached please find a patch that adds support for at least the T410s
> HDA codec.  Most likely it will also add support for the T410 and T510
> based models.
> 
> 
> The patch was derived from Ideapad support.  Support for the laptop's and
> docking-station output connectors as well as the docking-station microphone
> connector and the laptops internal devices has been tested.  Since it has been
> developed without a data-sheet available, support for digital outputs and the
> laptop's microphone input may well be incorrect.
> 
> Microphone mute functionality is not included:
> The microphone mute button seems to be reported through thinkpad_acpi key
> 0000101b.  The mute button LED seems to be wired to thinkpad_acpi led
> number 15.
> 
> Please apply.
> 
> Signed-off-by: Jens Taprogge <jens.taprogge@...rogge.org>

Thanks, applied now.  Just one fix I made in addition:

> @@ -2292,7 +2355,7 @@ static void cxt5066_set_mic_boost(struct hda_codec *codec)
>  		AC_VERB_SET_AMP_GAIN_MUTE,
>  		AC_AMP_SET_RIGHT | AC_AMP_SET_LEFT | AC_AMP_SET_OUTPUT |
>  			cxt5066_analog_mic_boost.items[spec->mic_boost].index);
> -	if (spec->ideapad) {
> +	if (spec->ideapad | spec->thinkpad) {

This should be a logical OR.


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/