| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20100415110232.7fc80ac1@linux.intel.com> Date: Thu, 15 Apr 2010 11:02:32 +0100 From: Alan Cox <alan@...ux.intel.com> To: Jonathan Cameron <jic23@....ac.uk> Cc: Éric Piel <E.A.B.Piel@...elft.nl>, linux-i2c@...r.kernel.org, khali@...ux-fr.org, linux-input@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 3/4] liss331d1: accelerometer driver > Err. Anyone get a feeling of deja vu here? > > http://lists.lm-sensors.org/pipermail/lm-sensors/2009-September/026706.html > > When Kalhan originally posted this driver it was pointed out that it > was compatible with the existing one. A complete lack of > communications lead to Kalhan (and someone else, might have been Eric > or Samu, can't recall) both implementing i2c support in the driver. > Can't find it right now but I'm fairly sure Kahlan reported that > worked fine for this chip as well? > > So looks like a lack of communications here and that Alan has picked > up an unnecessary driver. Thanks it does indeed - except for the retry logic which has come from another platform source and can be submitted in turn. Only other thing I see odd is that the existing driver prints a scary error message when there is no IRQ rather than just an info message. Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists