linux-kernel - Re: [PATCH 1/4] hmc6352: Add driver for the HMC6352 compass

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100415131153.0e383ef3@lxorguk.ukuu.org.uk>
Date:	Thu, 15 Apr 2010 13:11:53 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Joe Perches <joe@...ches.com>
Cc:	Kalhan Trisal <kalhan.trisal@...el.com>,
	Jonathan Cameron <kernel@...23.retrosnub.co.uk>,
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] hmc6352: Add driver for the HMC6352 compass

> Argument alignment

Makes it take more space

> Spacing

Mostly dropped

> Make chars static

Not sure I see the point (compiler generates good code anyway)

> Remove prefixes from dev_<level> logging

Good point.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/