linux-kernel - Re: AMD Geode i686

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100415173253.GB32023@caffeine.csclub.uwaterloo.ca>
Date:	Thu, 15 Apr 2010 13:32:53 -0400
From:	lsorense@...lub.uwaterloo.ca (Lennart Sorensen)
To:	Matteo Croce <technoboy85@...il.com>
Cc:	Lennart Sorensen <lsorense@...lub.uwaterloo.ca>,
	linux-kernel@...r.kernel.org, Alan Cox <alan@...rguk.ukuu.org.uk>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: AMD Geode i686

On Thu, Apr 15, 2010 at 07:20:27PM +0200, Matteo Croce wrote:
> On Thu, Apr 15, 2010 at 7:11 PM, Lennart Sorensen
> <lsorense@...lub.uwaterloo.ca> wrote:
> > On Mon, Mar 01, 2010 at 11:03:09PM +0100, Matteo Croce wrote:
> >> Hi,
> >> I have refreshed my AMD Geode i686 patch with NOPL and I have added a
> >> new nice feature.
> >> When a NOPL is found the parser looks for any NOPL after the current
> >> one, so they are emulated in bulk.
> >> Tested ok on a Pcengines Alix.
> >>
> >> Signed-off-by: Matteo Croce <technoboy85@...il.com>
> >>
> >> --- a/arch/x86/kernel/Makefile        2010-03-01 01:18:51.697166322 +0100
> >> +++ b/arch/x86/kernel/Makefile        2010-03-01 01:19:45.727095700 +0100
> >> @@ -89,6 +89,8 @@
> >>  obj-$(CONFIG_HPET_TIMER)     += hpet.o
> >>
> >>  obj-$(CONFIG_K8_NB)          += k8.o
> >> +obj-$(CONFIG_MGEODEGX1)              += nopl_emu.o
> >> +obj-$(CONFIG_MGEODE_LX)              += nopl_emu.o
> >>  obj-$(CONFIG_DEBUG_RODATA_TEST)      += test_rodata.o
> >>  obj-$(CONFIG_DEBUG_NX_TEST)  += test_nx.o
> >>
> >> --- a/arch/x86/kernel/cpu/amd.c       2010-03-01 01:18:51.737097341 +0100
> >> +++ b/arch/x86/kernel/cpu/amd.c       2010-03-01 01:19:27.867865836 +0100
> >> @@ -138,8 +138,10 @@
> >>       }
> >>
> >>       if (c->x86_model == 10) {
> >> -             /Index: linux-2.6.33/arch/x86/kernel/Makefile
> >> ===================================================================
> >> * AMD Geode LX is model 10 */
> >> -             /* placeholder for any needed mods */
> >> +             /* Geode only lacks the NOPL instruction to be i686,
> >> +                but we can emulate it in the exception handler
> >> +                and promote it to a class 6 cpu */
> >> +             boot_cpu_data.x86 = 6;
> >>               return;
> >>       }
> >>  }
> >> --- a/arch/x86/kernel/entry_32.S      2010-03-01 01:18:51.717096708 +0100
> >> +++ b/arch/x86/kernel/entry_32.S      2010-03-01 01:19:27.867865836 +0100
> >> @@ -960,7 +960,11 @@
> >>       RING0_INT_FRAME
> >>       pushl $0
> >>       CFI_ADJUST_CFA_OFFSET 4
> >> +#ifdef CONFIG_MGEODE_LX
> >> +     pushl $do_nopl_emu
> >> +#else
> >>       pushl $do_invalid_op
> >> +#endif
> >
> > How does this work for MGEODEGX1 when it looks for MGEODE_LX?  It seems
> > you made both link against the code above after all.  Is this wrong or
> > the above?
> >
> > Can it not work if you want to run a generic kernel on your Geode rather
> > than one built explicitly for the LX?  I build one kernel to run on
> > Geode SC1200 and Geode LX.
> >
> > --
> > Len Sorensen
> >
> 
> This code should work for Geode GX too.
> Try it and report success please

But if I don't have CONFIG_MGEODE_LX then what is going to call the
$do_nopl_emu in entry_32.S?

-- 
Len Sorensen
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/