linux-kernel - Re: [PATCH] Crypto: geode-aes: Fix some code style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100415143434.7b39e55f@debian>
Date:	Thu, 15 Apr 2010 14:34:34 -0400
From:	Andres Salomon <dilinger@...ued.net>
To:	linux-kernel@...r.kernel.org
Cc:	linux-geode@...badil.infradead.org, linux-crypto@...r.kernel.org
Subject: Re: [PATCH] Crypto: geode-aes: Fix some code style issues

On Thu, 15 Apr 2010 13:17:59 -0400
Chihau Chau <chihau@...il.com> wrote:

> From: Chihau Chau <chihau@...il.com>
> 
> This fixes some code style issues like:
> 
> - Use #include <linux/io.h> instead of <asm/io.h> and #include
>   <linux/delay.h> instead of <asm/delay.h>
> 
> - Use "foo *bar" instead of "foo * bar"
> 
> - Add a space after the for or while sentence and before the open
>   parenthesis '('
> 
> - Don't use assignments in a if condition
> 
> Signed-off-by: Chihau Chau <chihau@...il.com>

Looks obviously correct to me.

Acked-by: Andres Salomon <dilinger@...ian.org>


> ---
>  drivers/crypto/geode-aes.c |   36 ++++++++++++++++++++----------------
>  1 files changed, 20 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/crypto/geode-aes.c b/drivers/crypto/geode-aes.c
> index c7a5a43..09389dd 100644
> --- a/drivers/crypto/geode-aes.c
> +++ b/drivers/crypto/geode-aes.c
> @@ -15,14 +15,14 @@
>  #include <crypto/algapi.h>
>  #include <crypto/aes.h>
>  
> -#include <asm/io.h>
> -#include <asm/delay.h>
> +#include <linux/io.h>
> +#include <linux/delay.h>
>  

I don't see any delay functions being used anywhere; delay.h can
probably just be dropped.




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/