linux-kernel - Re: [PATCH] reiserfs: Fix corruption during shrinking of xattrs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.01.1004151632110.4069@bogon.housecafe.de>
Date:	Thu, 15 Apr 2010 16:49:15 -0700 (PDT)
From:	Christian Kujau <lists@...dbynature.de>
To:	Jeff Mahoney <jeffm@...e.com>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	ReiserFS Mailing List <reiserfs-devel@...r.kernel.org>,
	Edward Shishkin <edward.shishkin@...il.com>, stable@...nel.org,
	kernel@...ekman.nl, gregsurbey@...mail.com,
	Marco Gatti <marco.gatti@...il.com>
Subject: Re: [PATCH] reiserfs: Fix corruption during shrinking of xattrs

On Wed, 14 Apr 2010 at 01:32, Christian Kujau wrote:
> On Tue, 13 Apr 2010 at 15:39, Jeff Mahoney wrote:
> >  This patch fixes it to use new_size.
> 
> Tested-by: Christian Kujau <lists@...dbynature.de>

Dang. While this *does* seem to fix the "Input/output error after a large 
amount of files have their xattrs removed", it does not fix the initial 
issue in #14826, where occasionally this jdm-20002 message shows up.

I just tested this: I still have this calendarserver (caldavd) and it's 
heavily using xattr. I have removed everything under /var/spool/caldavd, 
started caldavd and am now importing a calendar. caldavd will now create 
files under /var/spool/caldavd, wil assign xattrs and read them. And just 
after a few operations, this happens again:

[138794.184926] REISERFS warning (device xvda3): jdm-20002 
reiserfs_xattr_get: Invalid hash for xattr 
(user.{http:%2F%2Ftwistedmatrix.com%2Fxml_namespace%2Fdav%2Fprivate%2F}quota-used) 
associated with [765 3282 0x0 SD]

[139238.740552] REISERFS warning (device xvda3): jdm-20002 
reiserfs_xattr_get: Invalid hash for xattr (user.{DAV:}displayname) 
associated with [765 3402 0x0 SD]

Inodes 3282, 3402, aka

./calendars/__uids__/afebe2f1-f51a-5859-af15-f22312ad6634
./calendars/__uids__/afebe2f1-f51a-5859-af15-f22312ad6634/2CC21268-C87E-4AE6-AFD4-33946D5621AB

....under /var/spool/caldavd. So it does happen for new files 
(directories in this case) indeed.

However, there's no file corruption, no I/O errors - I can still access 
the directory and its contents. The xattr information might be lost 
though. Bug #14826 somehow transformed into "my filesystem is corrupt", as 
the bug with the large amount of files/xattr seems to generate the same 
message in the syslog. But that's a different issue, methinks.

Christian.

[0] https://bugzilla.kernel.org/show_bug.cgi?id=14826
-- 
BOFH excuse #124:

user to computer ration too low.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/