linux-kernel - Re: [PATCH] fixed book E watchdog period register mask.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100415055715.GD15728@infomag.iguana.be>
Date:	Thu, 15 Apr 2010 07:57:15 +0200
From:	Wim Van Sebroeck <wim@...ana.be>
To:	Luuk Paulussen <luuk.paulussen@...iedtelesis.co.nz>
Cc:	Wim Van Sebroeck <wim@...ana.be>,
	Chris Friesen <cfriesen@...tel.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fixed book E watchdog period register mask.

Hi Luuk,

will add this one today or tomorrow, when I finished translating an audit report.

Kind regards,
Wim.

> A previous fix changed the WDTP function to use the period directly,
> rather than subtracting from 63.  However the mask generation was
> not changed, so the mask was coming out as 0.  This patch fixes it.
> 
> Signed-off-by: Luuk Paulussen <luuk.paulussen@...iedtelesis.co.nz>
> ---
>  drivers/watchdog/booke_wdt.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/watchdog/booke_wdt.c b/drivers/watchdog/booke_wdt.c
> index 8b724aa..500d383 100644
> --- a/drivers/watchdog/booke_wdt.c
> +++ b/drivers/watchdog/booke_wdt.c
> @@ -44,7 +44,7 @@ u32 booke_wdt_period = WDT_PERIOD_DEFAULT;
> 
>  #ifdef	CONFIG_FSL_BOOKE
>  #define WDTP(x)		((((x)&0x3)<<30)|(((x)&0x3c)<<15))
> -#define WDTP_MASK	(WDTP(0))
> +#define WDTP_MASK	(WDTP(0x3f))
>  #else
>  #define WDTP(x)		(TCR_WP(x))
>  #define WDTP_MASK	(TCR_WP_MASK)
> -- 
> 1.6.3.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/