linux-kernel - Re: [PATCH] colibri.h: Fix building for colibri 270...

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 16 Apr 2010 13:26:21 +0200
From:	Daniel Mack <daniel@...aq.de>
To:	Jakob Viketoft <jakob.viketoft@...sim.com>
Cc:	linux-kernel@...r.kernel.org, Eric Miao <eric.y.miao@...il.com>
Subject: Re: [PATCH] colibri.h: Fix building for colibri 270...

On Fri, Apr 16, 2010 at 01:17:58PM +0200, Jakob Viketoft wrote:
> Daniel Mack wrote:
> >On Fri, Apr 16, 2010 at 11:51:10AM +0200, Jakob Viketoft wrote:
> >>The recent addition of (Colibri) PXA3xx specific declarations breaks
> >>the building of the Colibri 270 with similar features.
> >
> >Hmm, I can't see any problem here. Which error did you get? Which boards
> >did you select in your config?
> 
> Hmmm, it appears I was slightly too fast on the trigger there. I
> encountered the problem some time ago when migrating fron 2.6.29 to
> 2.6.33.1 and a quick look made me think there was a linking problem.
> I'm finishing up this project now and wanted to push any relevant
> fixes upstream. However, the problem I seem to be getting is
> something different though:
> 
>   CC      drivers/pcmcia/pxa2xx_colibri.o
> In file included from drivers/pcmcia/pxa2xx_colibri.c:25:
> arch/arm/mach-pxa/include/mach/colibri.h:13: error: expected ')'
> before '*' token
> make[2]: *** [drivers/pcmcia/pxa2xx_colibri.o] Error 1
> make[1]: *** [drivers/pcmcia] Error 2
> make: *** [drivers] Error 2

It seems that mfp_cfg_t is unknown. Does including <mach/mfp.h> from
pxa2xx_colibri.c help? However, I can't see any problem on 2.6.34-rc4,
with or without CONFIG_MMC set, so that might only be related to 2.6.33.
Any change of trying this on a cutting edge tree, just to make sure?

Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/