linux-kernel - Re: Lockup inside of stop_machine() during modprobe aes (was Re: Another AR5008 hang)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100415172205.c1e57636.akpm@linux-foundation.org>
Date:	Thu, 15 Apr 2010 17:22:05 -0400
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Ben Gamari <bgamari.foss@...il.com>
Cc:	Johannes Berg <johannes@...solutions.net>,
	linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org,
	ath9k@...ema.h4ckr.net, Herbert Xu <herbert@...dor.hengli.com.au>
Subject: Re: Lockup inside of stop_machine() during modprobe aes (was Re:
 Another AR5008 hang)

On Tue, 06 Apr 2010 11:08:22 -0700 (PDT) Ben Gamari <bgamari.foss@...il.com> wrote:

> 
> ...
>
> I just built 2.6.34-rc3 with the appropriate fixes for the ACPI thermal lockdep
> issues and have attached the dmesg output of the crash below. It appears that
> modprobe is freezing with a few locks held while inserting aes.ko. In
> particular, it seems that the kernel is deadlocking inside of stop_machine()
> while flushing workqueues.
> 
> ...
>

My guess would be that ieee80211 is calling crypto->request_module()
under rtnl_lock, and the fact that rtnl_lock is held is causing
modprobe->stop_machine to not complete.

> P.S. I am now quite certain that I was mistaken in saying that 2.6.33 was
> affected. This seems to just be a 2.6.34 issue.

OK, thanks, I'll ask Rafael and Maciej to track this as a post-2.6.33
regression, probably wireless.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/