linux-kernel - [PATCH 2/2] Make BACKLIGHT_CLASS_DEVICE be selected automatically when needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <4BC8FFA4.2090906@tremplin-utc.net>
Date:	Sat, 17 Apr 2010 02:24:04 +0200
From:	Éric Piel <Eric.Piel@...mplin-utc.net>
To:	platform-driver-x86@...r.kernel.org, Andrew Morton <akpm@...l.org>
CC:	"Brown, Len" <len.brown@...el.com>,
	Matthew Garrett <mjg@...hat.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: [PATCH 2/2] Make BACKLIGHT_CLASS_DEVICE be selected automatically
 when needed

Many different modules depend on BACKLIGHT_CLASS_DEVICE, and are
situated in completely different places. In Kconfig, some used to "depend"
on it, while others "selected" it. Excepted for the drivers just below
the option, it's easier for the user to have it automatically
selected whenever needed. So we consistently "select" it for platform
and ACPI drivers.

Signed-off-by: Éric Piel <eric.piel@...mplin-utc.net>
---
 drivers/acpi/Kconfig         |    3 ++-
 drivers/platform/x86/Kconfig |   18 +++++++++---------
 2 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
index 93d2c79..50b45ca 100644
--- a/drivers/acpi/Kconfig
+++ b/drivers/acpi/Kconfig
@@ -161,8 +161,9 @@ config ACPI_BUTTON
 
 config ACPI_VIDEO
 	tristate "Video"
-	depends on X86 && BACKLIGHT_CLASS_DEVICE && VIDEO_OUTPUT_CONTROL
+	depends on X86 && VIDEO_OUTPUT_CONTROL
 	depends on INPUT
+	select BACKLIGHT_CLASS_DEVICE
 	select THERMAL
 	help
 	  This driver implements the ACPI Extensions For Display Adapters
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 9808ef3..f8a43de 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -19,9 +19,9 @@ config ACER_WMI
 	depends on ACPI
 	depends on LEDS_CLASS
 	depends on NEW_LEDS
-	depends on BACKLIGHT_CLASS_DEVICE
 	depends on SERIO_I8042
 	depends on RFKILL || RFKILL = n
+	select BACKLIGHT_CLASS_DEVICE
 	select ACPI_WMI
 	---help---
 	  This is a driver for newer Acer (and Wistron) laptops. It adds
@@ -57,9 +57,9 @@ config ASUS_LAPTOP
 	depends on !ACPI_ASUS
 	select LEDS_CLASS
 	select NEW_LEDS
-	select BACKLIGHT_CLASS_DEVICE
 	depends on INPUT
 	depends on RFKILL || RFKILL = n
+	select BACKLIGHT_CLASS_DEVICE
 	select INPUT_SPARSEKMAP
 	---help---
 	  This is the new Linux driver for Asus laptops. It may also support some
@@ -78,10 +78,10 @@ config DELL_LAPTOP
 	depends on X86
 	depends on DCDBAS
 	depends on EXPERIMENTAL
-	depends on BACKLIGHT_CLASS_DEVICE
 	depends on RFKILL || RFKILL = n
 	depends on POWER_SUPPLY
 	depends on SERIO_I8042
+	select BACKLIGHT_CLASS_DEVICE
 	default n
 	---help---
 	This driver adds support for rfkill and backlight control to Dell
@@ -101,8 +101,8 @@ config FUJITSU_LAPTOP
 	tristate "Fujitsu Laptop Extras"
 	depends on ACPI
 	depends on INPUT
-	depends on BACKLIGHT_CLASS_DEVICE
 	depends on LEDS_CLASS || LEDS_CLASS=n
+	select BACKLIGHT_CLASS_DEVICE
 	---help---
 	  This is a driver for laptops built by Fujitsu:
 
@@ -149,8 +149,8 @@ config HP_WMI
 config MSI_LAPTOP
 	tristate "MSI Laptop Extras"
 	depends on ACPI
-	depends on BACKLIGHT_CLASS_DEVICE
 	depends on RFKILL
+	select BACKLIGHT_CLASS_DEVICE
 	---help---
 	  This is a driver for laptops built by MSI (MICRO-STAR
 	  INTERNATIONAL):
@@ -168,7 +168,7 @@ config MSI_LAPTOP
 config PANASONIC_LAPTOP
 	tristate "Panasonic Laptop Extras"
 	depends on INPUT && ACPI
-	depends on BACKLIGHT_CLASS_DEVICE
+	select BACKLIGHT_CLASS_DEVICE
 	---help---
 	  This driver adds support for access to backlight control and hotkeys
 	  on Panasonic Let's Note laptops.
@@ -179,8 +179,8 @@ config PANASONIC_LAPTOP
 config COMPAL_LAPTOP
 	tristate "Compal Laptop Extras"
 	depends on ACPI
-	depends on BACKLIGHT_CLASS_DEVICE
 	depends on RFKILL
+	select BACKLIGHT_CLASS_DEVICE
 	---help---
 	  This is a driver for laptops built by Compal:
 
@@ -196,9 +196,9 @@ config COMPAL_LAPTOP
 config SONY_LAPTOP
 	tristate "Sony Laptop Extras"
 	depends on ACPI
-	select BACKLIGHT_CLASS_DEVICE
 	depends on INPUT
 	depends on RFKILL
+	select BACKLIGHT_CLASS_DEVICE
 	  ---help---
 	  This mini-driver drives the SNC and SPIC devices present in the ACPI
 	  BIOS of the Sony Vaio laptops.
@@ -420,7 +420,7 @@ config ACPI_WMI
 config MSI_WMI
 	tristate "MSI WMI extras"
 	depends on INPUT
-	depends on BACKLIGHT_CLASS_DEVICE
+	select BACKLIGHT_CLASS_DEVICE
 	select ACPI_WMI
 	select INPUT_SPARSEKMAP
 	help
-- 
1.7.0.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/