linux-kernel - Re: [regression] Sound not transferred to docking station after resume from StR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 19 Apr 2010 14:53:30 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Frans Pop <elendil@...net.nl>
Cc:	linux-kernel@...r.kernel.org, linux-pm@...ts.linux-foundation.org,
	alsa-devel@...a-project.org
Subject: Re: [regression] Sound not transferred to docking station after resume from StR

At Mon, 19 Apr 2010 14:39:44 +0200,
Frans Pop wrote:
> 
> On Monday 19 April 2010, Takashi Iwai wrote:
> > Or how about the patch below?
> 
> That fixes the problem too.
> 
> Please add my:
> Reported-and-tested-by: Frans Pop <elendil@...net.nl>

Thanks for a quick check.  But I found that the patch isn't fully
correct.

The patch below should suffice instead of the previous one.
Could you check it again?


thanks,

Takashi

---
diff --git a/sound/pci/hda/patch_analog.c b/sound/pci/hda/patch_analog.c
index 9cbd80c..afbe314 100644
--- a/sound/pci/hda/patch_analog.c
+++ b/sound/pci/hda/patch_analog.c
@@ -527,14 +527,6 @@ static int ad198x_suspend(struct hda_codec *codec, pm_message_t state)
 	ad198x_power_eapd(codec);
 	return 0;
 }
-
-static int ad198x_resume(struct hda_codec *codec)
-{
-	ad198x_init(codec);
-	snd_hda_codec_resume_amp(codec);
-	snd_hda_codec_resume_cache(codec);
-	return 0;
-}
 #endif
 
 static struct hda_codec_ops ad198x_patch_ops = {
@@ -547,7 +539,6 @@ static struct hda_codec_ops ad198x_patch_ops = {
 #endif
 #ifdef SND_HDA_NEEDS_RESUME
 	.suspend = ad198x_suspend,
-	.resume = ad198x_resume,
 #endif
 	.reboot_notify = ad198x_shutup,
 };
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/