linux-kernel - Re: trace-cmd: make Makefile rpm-friendly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1271703972.10448.5.camel@gandalf.stny.rr.com>
Date:	Mon, 19 Apr 2010 15:06:12 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	John Kacur <jkacur@...hat.com>
Cc:	Randy Dunlap <randy.dunlap@...cle.com>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: trace-cmd: make Makefile rpm-friendly

On Mon, 2010-04-19 at 20:11 +0200, John Kacur wrote:
> 
> On Mon, 19 Apr 2010, Randy Dunlap wrote:
> 
> > From: Randy Dunlap <randy.dunlap@...cle.com>
> > 
> > Update Makefile to support rpmbuild DESTDIR usage.
> 
> So, what would happen if you did
> make DESTDIR=/usr/local install ?
> 
> I think you would get /usr/local/usr/local
> So, I think I would NAK this patch.
> 
> I also don't believe there is anything magical about DESTDIR in a spec 
> file. Essentially, prefix in this makefile is equivalent to DESTDIR, so 
> you can replace DESTDIR with prefix in a spec template.
>  

NAK is too strong. I was looking at what perf does, and it basically
makes prefix and DESTDIR the same.

ifndef DESTDIR
prefix = $(HOME)
endif

We could do..

ifndef DESDIR
prefix = /usr/local/bin
endif

and then, if DESTDIR is not set, it would do the right thing.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/