linux-kernel - Re: [PATCH V5 1/3] perf & kvm: Enhance perf to collect KVM guest os statistics from host side

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100420060933.GC22277@elte.hu>
Date:	Tue, 20 Apr 2010 08:09:33 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	"Zhang, Yanmin" <yanmin_zhang@...ux.intel.com>
Cc:	Avi Kivity <avi@...hat.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Sheng Yang <sheng@...ux.intel.com>,
	linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
	Marcelo Tosatti <mtosatti@...hat.com>,
	oerg Roedel <joro@...tes.org>,
	Jes Sorensen <Jes.Sorensen@...hat.com>,
	Gleb Natapov <gleb@...hat.com>,
	Zachary Amsden <zamsden@...hat.com>, zhiteng.huang@...el.com,
	tim.c.chen@...el.com, Arnaldo Carvalho de Melo <acme@...radead.org>
Subject: Re: [PATCH V5 1/3] perf & kvm: Enhance perf to collect KVM guest os
 statistics from host side


* Ingo Molnar <mingo@...e.hu> wrote:

> 
> * Zhang, Yanmin <yanmin_zhang@...ux.intel.com> wrote:
> 
> >  unsigned long perf_misc_flags(struct pt_regs *regs)
> >  {
> >  	int misc = 0;
> > +
> >  	if (perf_guest_cbs && perf_guest_cbs->is_in_guest()) {
> > +		if (perf_guest_cbs->is_user_mode())
> > +			misc |= PERF_RECORD_MISC_GUEST_USER;
> > +		else
> > +			misc |= PERF_RECORD_MISC_GUEST_KERNEL;
> > +	} else if (user_mode(regs))
> > +		misc |= PERF_RECORD_MISC_USER;
> > +	else
> > +		misc |= PERF_RECORD_MISC_KERNEL;
> > +
> 
> We try to use balanced curly braces. I.e.:
> 
> 	if (x) {
> 		boo();
> 	} else {
> 		if (y)
> 			foo();
> 		else	
> 			bar();
> 	}	
> 
> And avoid unbalanced ones:
> 
> 	if (x) {
> 		boo();
> 	} else
> 		if (y)
> 			foo();
> 		else	
> 			bar();

Note, i fixed this in the patch and applied it to perf/core. (the invalid-C 
problem was causing build failures)

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/