lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 20 Apr 2010 11:15:08 +0100 From: David Howells <dhowells@...hat.com> To: "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com> Cc: dhowells@...hat.com, linux-kernel@...r.kernel.org, mingo@...e.hu, laijs@...fujitsu.com, dipankar@...ibm.com, akpm@...ux-foundation.org, mathieu.desnoyers@...ymtl.ca, josh@...htriplett.org, dvhltc@...ibm.com, niv@...ibm.com, tglx@...utronix.de, peterz@...radead.org, rostedt@...dmis.org, Valdis.Kletnieks@...edu, eric.dumazet@...il.com Subject: Re: [PATCH RFC tip/core/rcu 10/16] rcu: slim down rcutiny by removing rcu_scheduler_active and friends Paul E. McKenney <paulmck@...ux.vnet.ibm.com> wrote: > +void rcu_scheduler_starting(void) > +{ > + WARN_ON(nr_context_switches() > 0); > + rcu_scheduler_active = 1; > +} Since rcu_scheduler_active is a global variable, does it make sense to make this an inline function in the header file? It looks decidedly odd in its own include file as you've done it. Wouldn't the right way to do this be to split it into its own .c file and conditionally compile it in the Makefile? David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists