linux-kernel - Re: [PATCH] Staging: comedi: drivers: fix coding style issues in das08.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100420134233.GA27884@suse.de>
Date:	Tue, 20 Apr 2010 06:42:33 -0700
From:	Greg KH <gregkh@...e.de>
To:	Ian Abbott <abbotti@....co.uk>
Cc:	Gustavo Silva <silvagustavosilva@...il.com>,
	"fmhess@...rs.sourceforge.net" <fmhess@...rs.sourceforge.net>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Gustavo Silva <silvagustavo@...rs.sourceforge.net>
Subject: Re: [PATCH] Staging: comedi: drivers: fix coding style issues in
 das08.c

On Tue, Apr 20, 2010 at 01:18:28PM +0100, Ian Abbott wrote:
> On 19/04/10 07:21, Gustavo Silva wrote:
> > This is a patch to the das08.c file that fixes up the following issues
> > found by the checkpatch.pl tool.
> 
> > -*/
> >  /*
> > -Driver: das08
> > -Description: DAS-08 compatible boards
> > -Author: Warren Jasper, ds, Frank Hess
> > -Devices: [Keithley Metrabyte] DAS08 (isa-das08), [ComputerBoards] DAS08 (isa-das08),
> > -  DAS08-PGM (das08-pgm),
> > -  DAS08-PGH (das08-pgh), DAS08-PGL (das08-pgl), DAS08-AOH (das08-aoh),
> > -  DAS08-AOL (das08-aol), DAS08-AOM (das08-aom), DAS08/JR-AO (das08/jr-ao),
> > -  DAS08/JR-16-AO (das08jr-16-ao), PCI-DAS08 (das08),
> > -  PC104-DAS08 (pc104-das08), DAS08/JR/16 (das08jr/16)
> > -Status: works
> > -
> > -This is a rewrite of the das08 and das08jr drivers.
> > -
> > -Options (for ISA cards):
> > -        [0] - base io address
> > -
> > -Options (for pci-das08):
> > -        [0] - bus  (optional)
> > -        [1] = slot (optional)
> > -
> > -The das08 driver doesn't support asynchronous commands, since
> > -the cheap das08 hardware doesn't really support them.  The
> > -comedi_rt_timer driver can be used to emulate commands for this
> > -driver.
> > -*/
> > + * Driver: das08
> > + * Description: DAS-08 compatible boards
> > + * Author: Warren Jasper, ds, Frank Hess
> > + * Devices: [Keithley Metrabyte] DAS08 (isa-das08),
> > + * [ComputerBoards] DAS08 (isa-das08), DAS08-PGM (das08-pgm),
> > + * DAS08-PGH (das08-pgh), DAS08-PGL (das08-pgl), DAS08-AOH (das08-aoh),
> > + * DAS08-AOL (das08-aol), DAS08-AOM (das08-aom), DAS08/JR-AO (das08/jr-ao),
> > + * DAS08/JR-16-AO (das08jr-16-ao), PCI-DAS08 (das08),
> > + * PC104-DAS08 (pc104-das08), DAS08/JR/16 (das08jr/16)
> > + * Status: works
> > + *
> > + * This is a rewrite of the das08 and das08jr drivers.
> > + *
> > + * Options (for ISA cards):
> > + *             [0] - base io address
> > + *
> > + * Options (for pci-das08):
> > + *             [0] - bus  (optional)
> > + *             [1] = slot (optional)
> > + *
> > + * The das08 driver doesn't support asynchronous commands, since
> > + * the cheap das08 hardware doesn't really support them.  The
> > + * comedi_rt_timer driver can be used to emulate commands for this
> > + * driver.
> > + */
> 
> This part of the patch would screw up some scripts we have (in the CVS
> version of comedi) for extracting driver documentation from the source code.

What type of scripts are they and what is the requirements for them so
that we know not to mess them up?

And how about just using kerneldoc?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/