lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 20 Apr 2010 16:35:52 +0200 (CEST) From: Jiri Kosina <jkosina@...e.cz> To: Amerigo Wang <xiyou.wangcong@...il.com> Cc: Jan Kiszka <jan.kiszka@....de>, linux-kernel@...r.kernel.org, user-mode-linux-devel@...ts.sourceforge.net, Jeff Dike <jdike@...toit.com> Subject: Re: [PATCH 2/5] uml: Drop private round_down definition On Tue, 20 Apr 2010, Amerigo Wang wrote: > On Mon, Apr 19, 2010 at 11:53:05PM +0200, Jan Kiszka wrote: > >Already defined in kernel.h. The official version assumes that 'n' is > >power of two - which it is in our case. > > > >Signed-off-by: Jan Kiszka <jan.kiszka@....de> > >--- > > arch/um/sys-x86_64/signal.c | 2 -- > > 1 files changed, 0 insertions(+), 2 deletions(-) > > > >diff --git a/arch/um/sys-x86_64/signal.c b/arch/um/sys-x86_64/signal.c > >index 1a899a7..07797d1 100644 > >--- a/arch/um/sys-x86_64/signal.c > >+++ b/arch/um/sys-x86_64/signal.c > >@@ -165,8 +165,6 @@ struct rt_sigframe > > struct _fpstate fpstate; > > }; > > > >-#define round_down(m, n) (((m) / (n)) * (n)) > >- > > int setup_signal_stack_si(unsigned long stack_top, int sig, > > struct k_sigaction *ka, struct pt_regs * regs, > > siginfo_t *info, sigset_t *set) > > Shouldn't this signal.c #include <linux/kernel.h>? Well, it gets included implicitly through uaccess.h -> sched.h -> kernel.h. Applied, thanks. -- Jiri Kosina SUSE Labs, Novell Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists