linux-kernel - Re: [PATCH] x86: correctly wire up the newuname system call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100420145009.GA13376@hexapodia.org>
Date:	Tue, 20 Apr 2010 07:50:09 -0700
From:	Andy Isaacson <adi@...apodia.org>
To:	Christoph Hellwig <hch@....de>
Cc:	torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: correctly wire up the newuname system call

On Tue, Apr 20, 2010 at 05:31:02AM +0200, Christoph Hellwig wrote:
> Before commit e28cbf22933d0c0ccaf3c4c27a1a263b41f73859 64-bit x86 had
> a private implementation of sys_uname which was just called sys_uname,
> which other architectures used for the old uname.  Due to some merge
> issues with the uname refactoring patches we ended up calling the
> old uname version for both the old and new system call slots, which
> lead to the domainname filed never be set which caused failures with
                         ^^^^^ field.

> libnss_nis.
> 
> Reported-by: Andy Isaacson <adi@...apodia.org>
> Signed-off-by: Christoph Hellwig <hch@....de>
> 
> Index: linux-2.6/arch/x86/ia32/ia32entry.S
> ===================================================================
> --- linux-2.6.orig/arch/x86/ia32/ia32entry.S	2010-04-19 20:21:11.919003961 -0700
> +++ linux-2.6/arch/x86/ia32/ia32entry.S	2010-04-19 20:21:19.902005565 -0700
> @@ -626,7 +626,7 @@ ia32_sys_call_table:
>  	.quad stub32_sigreturn
>  	.quad stub32_clone		/* 120 */
>  	.quad sys_setdomainname
> -	.quad sys_uname
> +	.quad sys_newuname

Yes, that's the same patch I arrived at and fixes the issue for me.

Tested-by: Andy Isaacson <adi@...apodia.org>

Thanks,
-andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/