linux-kernel - Re: [BUG] sysfs: don't use allocated key for lockdep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100420162341.GA3232@suse.de>
Date:	Tue, 20 Apr 2010 09:23:41 -0700
From:	Greg KH <gregkh@...e.de>
To:	Jiri Kosina <jkosina@...e.cz>
Cc:	Lai Jiangshan <laijs@...fujitsu.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	WANG Cong <xiyou.wangcong@...il.com>,
	Tejun Heo <tj@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...e.hu>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [BUG] sysfs: don't use allocated key for lockdep

On Tue, Apr 20, 2010 at 06:09:27PM +0200, Jiri Kosina wrote:
> On Tue, 20 Apr 2010, Greg KH wrote:
> 
> > > lockdep_init_map() {
> > > ......
> > > 	/*
> > > 	 * Sanity check, the lock-class key must be persistent:
> > > 	 */
> > > 	if (!static_obj(key)) {
> > > 		printk("BUG: key %p not in .data!\n", key);
> > > 		DEBUG_LOCKS_WARN_ON(1);
> > > 		return;
> > > 	}
> > > 	lock->key = key;
> > > ......
> > > }
> > > 
> > > Could you please fix it.
> > 
> > All in-kernel attributes should now be fixed, so what exactly is the
> > remaining issue?
> 
> Are they?
> 
> How about my fix to drivers/hwmon/asus_atk0110.c for example, I sent last 
> week? http://lkml.org/lkml/2010/4/14/458

Ick, yes, it's still waiting to get sent to Linus, sorry about that,
still catching up on patches :(

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/