linux-kernel - Re: [PATCH] ACPI: DMI init_set_sci_en_on_resume for multiple Lenovo ThinkPads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1271783936.25170.131.camel@laptop>
Date:	Tue, 20 Apr 2010 12:18:56 -0500
From:	Jerone Young <jerone.young@...onical.com>
To:	Matthew Garrett <mjg59@...f.ucam.org>
Cc:	Alex Chiang <achiang@...onical.com>, lenb@...nel.org,
	colin.king@...onical.com, linux-acpi@...r.kernel.org,
	linux-kernel <linux-kernel@...r.kernel.org>, stable@...nel.org
Subject: Re: [PATCH] ACPI: DMI init_set_sci_en_on_resume for multiple
 Lenovo ThinkPads

On Tue, 2010-04-20 at 18:14 +0100, Matthew Garrett wrote:
> On Tue, Apr 20, 2010 at 11:56:41AM -0500, Jerone Young wrote:
> > Don't think this patch should go in as Lenovo is issuing a BIOS to
> > address this issue. On these Thinkpads listed and more. Seems to add
> > uneeded quirks in my opinion.
> > 
> > Though some over all patch may be good for all machines. As Windows
> > seems to be setting this bit on it's own.
> 
> It's a perfectly safe workaround that's limited to a well-bounded set of 
> machines and fixes a pretty serious problem with them. While I'd prefer 
> my approach and then a removal of the existing quirk entries, Alex's 
> patch makes more sense for stable. The BIOS update is as yet unreleased, 
> requires either Windows or an optical drive (which some of these 
> machines don't have) and is a far from discoverable solution to the 
> issue.

I could agree, but the only issue is if you go to the thinkpad-acpi or
ibm-acpi mailing list they would probably disagree as there have been
updates to the bios in the past required for proper functionality of
Thinkpads ;-) .. the bios update methods have not changed since then for
Thinkpads.

			Thanks,
				Jerone





--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/