linux-kernel - Re: [PATCH 0/4] enhanced reimplemention of the kfifo API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100420201642.GA32373@suse.de>
Date:	Tue, 20 Apr 2010 13:16:42 -0700
From:	Greg KH <gregkh@...e.de>
To:	stefani@...bold.net
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	andi@...stfloor.org, alan@...rguk.ukuu.org.uk, tytso@....edu,
	iws@...o.caltech.edu
Subject: Re: [PATCH 0/4] enhanced reimplemention of the kfifo API

On Tue, Apr 20, 2010 at 10:06:36PM +0200, stefani@...bold.net wrote:
> From: Stefani Seibold <stefani@...bold.net>
> 
> This is a complete reimplementation of the new kfifo API, which is now 
> really generic, type save and type definable. 
> 
> The API is still stable, no code which use the current  kfifo API must 
> be modified!
> 
> Here are the results of the text section usage:
> 
> Example 1:
>                         kfifo_put/_get  kfifo_in/out    current kfifo
> dynamic allocated       0x000002a8      0x00000291      0x00000299
> in place                0x00000291      0x0000026e      0x00000273
> 
> kfifo.c                 new             old
> text section size       0x00000be5      0x000008b2
> 
> As you can see, kfifo_put/kfifo_get creates a little bit more code than 
> kfifo_in/kfifo_out, but it is much faster (the code is inline).
> 
> The code is complete hand crafted and optimized. The text section size is as 
> small as possible. You get all the fifo handling in only 3 kb. This includes 
> type safe fix size records, dynamic records and DMA handling.
> 
> This should be the final version. All requested features are implemented.
> 
> Note: Most features of this API doesn't have any users. All functions which
> are not used in the next 9 months will be removed. So, please adapt your
> drivers and other sources as soon as possible to the new API and post it. 
> 
> This are the features which are currently not used in the kernel:
> 
> kfifo_to_user()
> kfifo_from_user()
> kfifo_dma_....() macros
> kfifo_esize()
> kfifo_recsize()
> kfifo_put()
> kfifo_get()
> the fixed size record elements, exclude "unsigned char" fifo's and
> the variable size records fifo's

If you have features that have no users, why add them?  Do you think
that some drivers need/want these features?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/