linux-kernel - Re: [PATCHv5 2.6.34-rc4 4/5] mxc: Add generic USB HW initialization for MX51

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <y2gfa686aa41004191818o126cc59cs7b551103b91f2266@mail.gmail.com>
Date:	Mon, 19 Apr 2010 19:18:42 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Daniel Mack <daniel@...aq.de>
Cc:	Dinh.Nguyen@...escale.com, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux@....linux.org.uk,
	s.hauer@...gutronix.de, valentin.longchamp@...l.ch,
	bryan.wu@...onical.com, amit.kucheria@...onical.com,
	r.herring@...escale.com, Jun.Li@...escale.com,
	xiao-lizhang@...escale.com
Subject: Re: [PATCHv5 2.6.34-rc4 4/5] mxc: Add generic USB HW initialization 
	for MX51

On Mon, Apr 19, 2010 at 7:13 PM, Daniel Mack <daniel@...aq.de> wrote:
> On Mon, Apr 19, 2010 at 05:27:03PM -0500, Dinh.Nguyen@...escale.com wrote:
>> +             /* allow controller to reset, and leave time for
>> +              * the ULPI transceiver to reset too.
>> +              */
>> +             msleep(100);
>
> Does the sleep really need to be that long? You're holding off the
> kernel's by that. If we can reduce that, we should certainly do so.

msleep() should be fine since Linux will schedule something else.
mdelay(100) would be bad indeed.

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/