linux-kernel - Re: [PATCH] Mass Storage Gadget: Handle eject request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <op.vbh83qxw7p4s8u@pikus>
Date:	Wed, 21 Apr 2010 11:10:28 +0200
From:	Michał Nazarewicz <m.nazarewicz@...sung.com>
To:	fabien.chouteau@...il.com, linux-usb@...r.kernel.org
Cc:	Fabien Chouteau <fabien.chouteau@...co.com>,
	David Brownell <dbrownell@...rs.sourceforge.net>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Peter Korsgaard <jacmet@...site.dk>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Mass Storage Gadget: Handle eject request

On Tue, 20 Apr 2010 10:34:09 +0200, <fabien.chouteau@...il.com> wrote:
> Handle eject request + sysfs entries to detect ejected LUN and suspended gadget.

> diff --git a/drivers/usb/gadget/f_mass_storage.c b/drivers/usb/gadget/f_mass_storage.c
> index f4911c0..af13a2f 100644
> --- a/drivers/usb/gadget/f_mass_storage.c
> +++ b/drivers/usb/gadget/f_mass_storage.c
> @@ -2412,6 +2449,26 @@ static void fsg_disable(struct usb_function *f)
>  	raise_exception(fsg->common, FSG_STATE_CONFIG_CHANGE);
>  }
>+static void fsg_suspend(struct usb_function *f)
> +{
> +	struct fsg_dev	*fsg = fsg_from_func(f);
> +	struct fsg_lun	*curlun = fsg->common->luns;
> +	int		i;
> +
> +	for (i = 0; i < fsg->common->nluns; i++, curlun++)
> +		curlun->suspended = 1;
> +}
> +
> +static void fsg_resume(struct usb_function *f)
> +{
> +	struct fsg_dev	*fsg = fsg_from_func(f);
> +	struct fsg_lun	*curlun = fsg->common->luns;
> +	int		i;
> +
> +	for (i = 0; i < fsg->common->nluns; i++, curlun++)
> +		curlun->suspended = 0;
> +}
> +

Clearly, suspend seems like a state of the mass storage function
as a whole rather then attribute of each logical unit so I think
it'll be better to make it global for the mass storage function
rather then per-LUN.

Even more so, it's a state of the whole gadget so in my opinion the
whole code should be moved the the gadget rather then kept in
a function!

Going even further, I would propose an sysfs entry to be added to
the composite framework as a single generic interface rather then
hacking it in each gadget/function that might need to export this
information to user space.

This provided that there is no easy way of gaining that information
in user space through same other sysfs entry.

Other then that, the patch seems fine.

-- 
Best regards,                                           _     _
  .o. | Liege of Serenely Enlightened Majesty of       o' \,=./ `o
  ..o | Computer Science,  Michał "mina86" Nazarewicz     (o o)
  ooo +---[mina86@...a86.com]---[mina86@...ber.org]---ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/