linux-kernel - Re: pci_get_dev_by_id() from interrupt handlers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100421105515.GJ31537@amd.com>
Date:	Wed, 21 Apr 2010 12:55:15 +0200
From:	Joerg Roedel <joerg.roedel@....com>
To:	Peter Zijlstra <peterz@...radead.org>
CC:	Greg KH <greg@...ah.com>, Joerg Roedel <joro@...tes.org>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: pci_get_dev_by_id() from interrupt handlers

On Wed, Apr 21, 2010 at 12:46:56PM +0200, Peter Zijlstra wrote:
> On Wed, 2010-04-21 at 12:41 +0200, Joerg Roedel wrote:
> > On Wed, Apr 21, 2010 at 12:21:11PM +0200, Peter Zijlstra wrote:
> > > On Wed, 2010-04-21 at 12:05 +0200, Joerg Roedel wrote:
> > > > 
> > > > > Why not do the whole thing in an interrupt task as the whole thing
> > > > > sounds like something that shouldn't be done in interrupt context,
> > > > > right?  Now that we have this type of functionality, we should take
> > > > > advantage of it :)
> > > > 
> > > > Ok, I think I move the IOMMU interrupt handling to a tasklet.
> > > > 
> > > tasklet is softirq context, and is not what gregkh was talking about.
> > > 
> > > You'd still need to change the klist spinlock to be softirq-safe.
> > 
> > Ah right. Thanks for pointing this out. I couldn't find much about the
> > interrupt tasks. Is it about the request_threaded_irq interface? And
> > this would be run in the context of a kernel thread, right?
> 
> Right, request_threaded_irq() is what was meant, the comment there does
> a good job of describing how to use it.

Ok, thanks. I am going to use this interface instead.

	Joerg


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/