| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 21 Apr 2010 06:26:02 -0700 From: "Justin P. Mattock" <justinmattock@...il.com> To: Joe Perches <joe@...ches.com> CC: Alexey Dobriyan <adobriyan@...il.com>, trivial@...nel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] Whitespace Coding style fixes. On 04/21/2010 12:34 AM, Joe Perches wrote: > On Wed, 2010-04-21 at 00:09 -0700, Justin P. Mattock wrote: >> On 04/21/2010 12:03 AM, Alexey Dobriyan wrote: >>> You screw up git-blame. >> how does this patch screw it up? > > Alexey just doesn't like whitespace patches. > > Whitespace patches don't really "screw up" git blame. > > git blame displays the current version of a file > with line-by-line commits and the date each line > was last modified. > > So whitespace changes make it harder to find which patch > introduced the last logical change for a particular line. > > A more interactive git blame with history backtracking > might help keep Alexey happier but who knows for sure... > > ahh.. so after adding this patch, and committing it in my branch the doing git blame security/commoncap.c only shows something from James Morris instead of what my change had brought. Alright I can see why it screws things up.. I'll not (L)indent the whole tree then... Justin P. Mattock -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists