lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 21 Apr 2010 09:30:20 -0500 (CDT) From: Christoph Lameter <cl@...ux-foundation.org> To: Mel Gorman <mel@....ul.ie> cc: Andrew Morton <akpm@...ux-foundation.org>, Andrea Arcangeli <aarcange@...hat.com>, Adam Litke <agl@...ibm.com>, Avi Kivity <avi@...hat.com>, David Rientjes <rientjes@...gle.com>, Minchan Kim <minchan.kim@...il.com>, KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>, KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>, Rik van Riel <riel@...hat.com>, linux-kernel@...r.kernel.org, linux-mm@...ck.org Subject: Re: [PATCH 04/14] mm,migration: Allow the migration of PageSwapCache pages On Tue, 20 Apr 2010, Mel Gorman wrote: > @@ -520,10 +521,12 @@ static int move_to_new_page(struct page *newpage, struct page *page) > else > rc = fallback_migrate_page(mapping, newpage, page); > > - if (!rc) > - remove_migration_ptes(page, newpage); > - else > + if (rc) { > newpage->mapping = NULL; > + } else { > + if (remap_swapcache) > + remove_migration_ptes(page, newpage); > + } You are going to keep the migration ptes after the page has been unlocked? Or is remap_swapcache true if its not a swapcache page? Maybe you meant if (!remap_swapcache) ? > unlock_page(newpage); > > > skip_unmap: > if (!page_mapped(page)) > - rc = move_to_new_page(newpage, page); > + rc = move_to_new_page(newpage, page, remap_swapcache); > > - if (rc) > + if (rc && remap_swapcache) > remove_migration_ptes(page, page); > rcu_unlock: > Looks like you meant !remap_swapcache -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists