linux-kernel - Re: [PATCH 1/2] Composite framework: Add suspended sysfs entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100421180552.GB24842@suse.de>
Date:	Wed, 21 Apr 2010 11:05:52 -0700
From:	Greg KH <gregkh@...e.de>
To:	fabien.chouteau@...il.com
Cc:	linux-usb@...r.kernel.org,
	Fabien Chouteau <fabien.chouteau@...co.com>,
	David Brownell <dbrownell@...rs.sourceforge.net>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Michal Nazarewicz <m.nazarewicz@...sung.com>,
	Roel Kluin <roel.kluin@...il.com>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	Tejun Heo <tj@...nel.org>,
	Christoph Lameter <cl@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] Composite framework: Add suspended sysfs entry

On Wed, Apr 21, 2010 at 05:38:21PM +0200, fabien.chouteau@...il.com wrote:
> From: Fabien Chouteau <fabien.chouteau@...co.com>
> 
> 
> Signed-off-by: Fabien Chouteau <fabien.chouteau@...co.com>
> ---
>  drivers/usb/gadget/composite.c |   21 +++++++++++++++++++++
>  include/linux/usb/composite.h  |    1 +
>  include/linux/usb/gadget.h     |    4 ++++
>  3 files changed, 26 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c
> index 09289bb..a5352f3 100644
> --- a/drivers/usb/gadget/composite.c
> +++ b/drivers/usb/gadget/composite.c
> @@ -898,6 +898,18 @@ static void composite_disconnect(struct usb_gadget *gadget)
>  
>  /*-------------------------------------------------------------------------*/
>  
> +static ssize_t composite_show_suspended(struct device *dev,
> +					struct device_attribute *attr,
> +					char *buf)

As you added a sysfs file, it is required that you also add an entry in
Documentation/ABI/ that describes the file and what it is for.  Please
respin this with that added to the patch.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/