linux-kernel - Re: [PATCH 1/2] ibft: Update iBFT handling for v1.03 of the spec.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100421142634.ea5ca8a5.akpm@linux-foundation.org>
Date:	Wed, 21 Apr 2010 14:26:34 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Konrad Rzeszutek Wilk <konrad@...nel.org>
Cc:	linux-kernel@...r.kernel.org, gpxe-devel@...erboot.org,
	Peter Jones <pjones@...hat.com>
Subject: Re: [PATCH 1/2] ibft: Update iBFT handling for v1.03 of the spec.

On Fri,  9 Apr 2010 14:21:27 +0000
Konrad Rzeszutek Wilk <konrad@...nel.org> wrote:

> From: Peter Jones <pjones@...hat.com>
> 
> - Use struct acpi_table_ibft instead of struct ibft_table_header
> - Don't do reserve_ibft_region() on UEFI machines (section 1.4.3.1)
> - If ibft_addr isn't initialized when ibft_init() is called, check for
>   ACPI-based tables.
> 
> Author:      Peter Jones <pjones@...hat.com>
> Signed-off-by: Konrad Rzeszutek Wilk <konrad@...nel.org>
> Reviewed-by: Mike Christie <michaelc@...wisc.edu>

This should have Peter's Signed-off-by:, please.

>
> ...
>
> +#ifdef CONFIG_ACPI
> +static int __init acpi_find_ibft(struct acpi_table_header *header)
> +{
> +	ibft_addr = (struct acpi_table_ibft *)header;

container_of() would be better here.  And maybe elsewhere, too.

> +	return 0;
> +}
> +#endif /* CONFIG_ACPI */

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/