linux-kernel - Re: [PATCH] max732x: Correct nr_port checking off by one error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100421145552.72307e9c.akpm@linux-foundation.org>
Date:	Wed, 21 Apr 2010 14:55:52 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	axel.lin@...il.com
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Eric Miao <eric.miao@...vell.com>
Subject: Re: [PATCH] max732x: Correct nr_port checking off by one error

On Mon, 12 Apr 2010 15:29:16 +0800
Axel Lin <axel.lin@...il.com> wrote:

> Setup both client_group_a and client_group_b if nr_port > 8 (not
> including nr_port==8).
> 

OK, that's what the patch does.  But why does it do it?

In other words, when fixing a bug, please include a description of that
bug!  And, if it's not obvious from the description, please also describe
the user-visible effects of that bug.  So the poor schmuck at the other
end (ie: me) can work out which kernel(s) the fix should be merged
into.

> 
> diff --git a/drivers/gpio/max732x.c b/drivers/gpio/max732x.c
> index f786824..51b02c6 100644
> --- a/drivers/gpio/max732x.c
> +++ b/drivers/gpio/max732x.c
> @@ -285,14 +285,14 @@ static int __devinit max732x_probe(struct
> i2c_client *client,

The patch is wordwrapped.

>         switch (client->addr & 0x70) {
>         case 0x60:
>                 chip->client_group_a = client;
> -               if (nr_port > 7) {
> +               if (nr_port > 8) {

And has its tabs replaced with spaces.  sorry-youre-using-gmail.

Please see if you can get that fixed up for next time
(Documentation/email-clients.txt has some tips).  Worst-case, use
text/plain attachments.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/