linux-kernel - Re: [PATCH 1/2] input: Add support of Synaptics Clickpad device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 21 Apr 2010 08:32:30 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] input: Add support of Synaptics Clickpad device

At Tue, 20 Apr 2010 22:44:55 -0700,
Dmitry Torokhov wrote:
> 
> On Mon, Apr 19, 2010 at 12:29:49PM +0200, Takashi Iwai wrote:
> > Hi Dmitry,
> > 
> > At Mon, 19 Apr 2010 01:32:22 -0700,
> > Dmitry Torokhov wrote:
> > > 
> > > Hi Takashi,
> > > 
> > > On Wed, Apr 14, 2010 at 05:10:22PM +0200, Takashi Iwai wrote:
> > > > Add the detection of Synaptics Clickpad device.
> > > > The device can be detected a new query command 0x0c.  The clickpad
> > > > flags are in cap[0]:4 and cap[1]:0 bits.  But, the driver checks
> > > > first the product id bits in the ext capabilities to be sure, so
> > > > that it skips the new check on older devices.
> > > > 
> > > 
> > > Instead of looking at the product id, can we check the number of
> > > supported extended capabilities queries and act accordingly, like the
> > > patch below?
> > 
> > Yes, it worked.  (Though, I've tested only new machines.)
> > 
> 
> 
> Seems to be working on older (at least one ;) ) as well.
> 
> > 
> > > @@ -162,6 +163,16 @@ static int synaptics_capability(struct psmouse *psmouse)
> > >  				priv->ext_cap &= 0xff0fff;
> > >  		}
> > >  	}
> > > +
> > > +	if (SYN_EXT_CAP_REQUESTS(priv->capabilities) >= 4) {
> > > +		if (synaptics_send_cmd(psmouse, SYN_QUE_EXT_CAPAB_0C, cap)) {
> > > +			printk(KERN_ERR "Synaptics claims to have extended capability 0x0c,"
> > > +			       " but I'm not able to read it.");
> > 
> > Here missing a newline, BTW.
> > 
> 
> Fixed. Thank you for testing. I have that patch in 'for-linus' for .34.
> Please push your synaptics X changes upstream as well.

Thanks.  It was already submitted.
I'm going to repost the revised X patch later.


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/